Notify the user when voice training fails - #14
Open
jgsaez9 wants to merge 1 commit into
Open
Conversation
Training runs in the background when the main entry is set up or its options change. On failure (backend unreachable, audio files not found, ...) the only signal was a log line, so users just saw no recognition result later with no idea why. Track the last training error on the recognition instance and surface it as a persistent notification, dismissed automatically on the next successful train. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Voice training runs in the background when the main entry is set up or its options change. When it fails - backend unreachable, audio files not found under the media folder, etc. - the only signal is a log line. Users just see "no result" at recognition time (or the
speaker_recognition_detectedevent never firing) with no idea why. This was a very common source of confusion during setup.Fix
last_train_error).This turns silent failures into an actionable message in the UI.