Store recognition results per STT entity and consume on use - #13
Open
jgsaez9 wants to merge 1 commit into
Open
Conversation
The recognised speaker was stored in a single shared `hass.data` slot (`last_result`). With more than one satellite this is unsafe: concurrent utterances overwrite each other, and because the value was never cleared, a conversation turn with no fresh recognition could still be enriched with a result from up to 5 seconds earlier. - The STT proxy now stores results keyed by its entity id. - The conversation proxy takes the freshest result within the freshness window and consumes it, so a recognition is applied to at most one turn and stale results are never reused. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The recognised speaker was stored in a single shared
hass.dataslot (speaker_recognition.last_result). Two issues follow:Fix
entity_id(hass.data[DOMAIN]["results"][entity_id]).This does not fully correlate a specific satellite's audio to its conversation turn (Assist does not expose a shared run id to both the STT and conversation entities), but it removes the shared-slot overwrite and the stale-reuse window, which are the practical failure modes.