Use a sensible default minimum confidence (0.7) - #11
Open
jgsaez9 wants to merge 1 commit into
Open
Conversation
`DEFAULT_MIN_CONFIDENCE` was `0.0`, which is used as the default for the `min_confidence` slider when adding/configuring a conversation proxy. With a threshold of `0.0`, *any* recognition result -- even one with a near-zero score -- would set the conversation `user_id`, misattributing who is speaking. Default to `0.7`, a conservative threshold that avoids applying low-confidence matches. Existing configured proxies keep their saved value; this only changes the default for newly created ones. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DEFAULT_MIN_CONFIDENCEis0.0. It is used as the default for themin_confidenceslider when adding or configuring a conversation proxy. With a threshold of0.0, any recognition result - even one with a near-zero similarity score - sets the conversationuser_id, so the speaker is frequently misattributed.Fix
Default to
0.7, a conservative threshold that only applies reasonably confident matches. This also aligns the default with the fallback already used inconversation.py.No other behaviour change.