Skip to content

Handle tcp-ip-forward global request responses. - #148

Open
jimmyvanhest wants to merge 1 commit into
Eugeny:masterfrom
dutchanddutch:global-response-handling
Open

Handle tcp-ip-forward global request responses.#148
jimmyvanhest wants to merge 1 commit into
Eugeny:masterfrom
dutchanddutch:global-response-handling

Conversation

@jimmyvanhest

Copy link
Copy Markdown

When a tcp-ip-forward global request is sent a REQUEST_SUCCESS or a REQUEST_FAILURE response is expected and should be handled. this is also an opportunity to parse and return the port number returned by the server.

@Eugeny

Eugeny commented Mar 7, 2023

Copy link
Copy Markdown
Owner

Welcome and thank you for your contribution!

Unfortunately read_u32 is failing when there's no port info in the request (e.g. in the success response of the cancel-tcpip-forward request)

The session should either remember the type of the last global request and act accordingly or in the worst case, just ignore a missing port field.

@Eugeny Eugeny added the help wanted Extra attention is needed label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants