fix: replace PatternType.getByIdentifier() with PatternTypeProvider#6553
Open
1wairesd wants to merge 1 commit into
Open
fix: replace PatternType.getByIdentifier() with PatternTypeProvider#65531wairesd wants to merge 1 commit into
1wairesd wants to merge 1 commit into
Conversation
PatternType.getByIdentifier() causes IncompatibleClassChangeError on 1.19.4 due to a mismatch between Methodref and InterfaceMethodref bytecode constants when compiled against a newer API. Introduce PatternTypeProvider with two implementations: - LegacyPatternTypeProvider: iterates PatternType.values() for 1.19.4 and older where PatternType is still an enum - ModernPatternTypeProvider: uses Registry.BANNER_PATTERN for 1.20.5+ Update MetaItemStack.addBannerMeta to resolve PatternType through the provider instead of calling the deprecated static method directly.
Member
|
Here's the PR template you ignored. https://github.com/EssentialsX/Essentials/blob/2.x/.github/PULL_REQUEST_TEMPLATE/bug-fix.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PatternType.getByIdentifier() causes IncompatibleClassChangeError on 1.19.4 due to a mismatch between Methodref and InterfaceMethodref bytecode constants when compiled against a newer API.
Introduce PatternTypeProvider with two implementations:
Update MetaItemStack.addBannerMeta to resolve PatternType through the provider instead of calling the deprecated static method directly.
You need to select a pull request template!
If you're adding a new feature, copy and paste the following parameter at the end of the URL:
?template=new-feature.md
If you're fixing a bug, copy and paste the following parameter at the end of the URL:
?template=bug-fix.md
For more information about contributing to EssentialsX, see CONTRIBUTING.md:
https://github.com/EssentialsX/Essentials/blob/2.x/CONTRIBUTING.md