Skip to content

feat: Support for % in ecconomy by remvoing the default: throw new In…#6548

Open
Javarev1 wants to merge 1 commit into
EssentialsX:2.xfrom
Javarev1:2.x
Open

feat: Support for % in ecconomy by remvoing the default: throw new In…#6548
Javarev1 wants to merge 1 commit into
EssentialsX:2.xfrom
Javarev1:2.x

Conversation

@Javarev1
Copy link
Copy Markdown

Support for % in ecconomy by remvoing the default: throw new InvalidModifierException() branch in the parser.

…validModifierException() branch in the parser.
@mdcfe
Copy link
Copy Markdown
Member

mdcfe commented May 28, 2026

This change does not add support for % signs. There are several places where currency format symbols can be passed into formatting calls where % would be parsed as a placeholder and so cause hard-to-track-down exceptions elsewhere, both within and outside of EssentialsX's control, and so the safest option is to forbid the % sign.

Edit: it's not even clear what functionality this PR is trying to add. Please elaborate by filling out the PR template properly, as requested when you opened the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants