Adding search functionality to Hub - #96
Open
raykendo wants to merge 6 commits into
Open
Conversation
added 6 commits
July 29, 2020 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is to possibly address #5, where you wanted to search for hub items. I wasn't sure how to search for a Hub by itself, since those aren't necessarily exposed as items in an org. What this does is search for hub items like Initiatives, Sites, Pages, etc. and creates a list of those items. I attempted to follow the patterns you set in other searches.
If this wasn't the functionality you were looking for, feel free to dismiss this one.
EDIT: Didn't realize it, but this pull request also includes managing the layout of a Hub Page in sites.py. Was going to add that in a separate PR, but oh well.