Skip to content

Delete activity - #48

Open
TharinduSilva2019774 wants to merge 11 commits into
Eshaan-byte:mainfrom
TharinduSilva2019774:delete_activity
Open

Delete activity#48
TharinduSilva2019774 wants to merge 11 commits into
Eshaan-byte:mainfrom
TharinduSilva2019774:delete_activity

Conversation

@TharinduSilva2019774

@TharinduSilva2019774 TharinduSilva2019774 commented Oct 19, 2025

Copy link
Copy Markdown

🌱 Carbon Footprint Tracker - Pull Request

Implemented features necessary to allow users to delete recent activity entries.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🎨 Style/UI update
  • ♻️ Code refactoring
  • ⚡ Performance improvement
  • 🧪 Test addition or update

Related Issue

Fixes #4

Changes Made

  • Add delete button to activity history items
  • Implement confirmation dialog
  • Update dashboard data when activity is deleted
  • Show success/error messages
  • Update database operations

Screenshots (if applicable)

image image

Testing

  • I have tested this change locally
  • I have tested on mobile devices
  • I have tested on different browsers
  • All existing tests pass
  • I have added new tests (if applicable)

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes


For Maintainers

  • Code review completed
  • Tests passing
  • Documentation updated
  • Ready to merge

Thank you for contributing to making digital sustainability more accessible! 🌍

This repository participates in Hacktoberfest 2025! 🎃

@TharinduSilva2019774

Copy link
Copy Markdown
Author

@Eshaan-byte Please check

@Eshaan-byte

Copy link
Copy Markdown
Owner

Thanks for the contribution @TharinduSilva2019774! 🎉

I noticed this PR includes two separate features:

  1. ✅ Delete activity (addresses Issue 4: Implement Activity Deletion #4)
  2. ➕ CSV export (not in Issue 4: Implement Activity Deletion #4)

While both features are useful, we generally prefer to keep PRs focused on a single issue for easier review and maintenance.

Request:
Could you please split this into two separate PRs?

  1. PR ## Issue 1: Add Music Streaming Activity Type #1: Delete activity feature only (everything except CSV export)
  2. PR ## Issue 2: Create Dark Mode Toggle #2: CSV export feature (create a new issue first, then reference it)

This will help us:

  • Review each feature independently
  • Merge the delete feature quickly
  • Have proper discussion about CSV export requirements

Would you be able to do this? Let me know if you need help! 🙏

@TharinduSilva2019774

TharinduSilva2019774 commented Oct 20, 2025

Copy link
Copy Markdown
Author

Hi @Eshaan-byte thanks for the review! 🙌
Just to clarify this PR only contains the delete-activity feature. I didn’t add anything related to CSV export in this branch.

It might be a misunderstanding could you point out which file or change looked like CSV export so I can double check where the confusion is coming from?

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue 4: Implement Activity Deletion

2 participants