Repository navigation
M4: a finding per requirement, citing its clause - #13
Merged
Merged
Conversation
`luxpath check` lists, for every route, area and point, each EN 1838:2024 requirement that applies to it with its clause (luxpath_rules::en1838). Every finding is "cannot verify": the values are not verified against the standard's text (gap 4), or the element's numbers could not be computed, which the finding then says. Scenes gain the area kinds the 2024 edition added: toilets (5.4.1), swimming-pool (5.4.2), plant-room (5.4.3) and local-area (7.1). A test keeps the code's requirements, the parity list and the coverage table in agreement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
luxpath checknow lists, under "Requirements (EN 1838:2024)", every requirement that applies to each route, area and point, citing its clause. For example:luxpath_rules::en1838holds the requirements on elements: id (the parity entry), clause, our own short title, and which element kinds each applies to. Requirements on the whole installation (glare, duration, response time, Ra) are not listed yet.toilets(5.4.1),swimming-pool(5.4.2),plant-room(5.4.3) andlocal-area(7.1). They are computed over their whole outline, and the assumptions now say so. Only open areas leave a border out.parity/features.tomland the clause column ofdocs/standards-parity.md.When the standard is bought, M4 gives each requirement its threshold, tested on both sides.
How you verified it
cargo xtask cievery_element_gets_a_finding_per_requirement_citing_its_clause: fails if findings pass, or a clause changesa_finding_on_an_element_that_cannot_be_computed_says_why: fails if the element's reason is droppedevery_requirement_is_in_the_parity_list_and_the_coverage_table_with_its_clause: fails on a clause the docs don't haveevery_area_kind_reads_by_its_name(scene)every_example_…: fails without the report's requirements sectionLife safety (AGENTS.md §2)
Never panic (AGENTS.md §3)
unwrap/expect/panic!/indexing on input outside testsProvenance (AGENTS.md §1)
Records
parity/features.toml: notes onen1838.specific-areasanden1838.local-areadocs/status.md,docs/scene-format.mdand theROADMAP.mdprogress log updated🤖 Generated with Claude Code