Skip to content

[codex] fix(config): remove flat results remote alias#1562

Merged
christso merged 2 commits into
mainfrom
results-remote-schema
Jun 29, 2026
Merged

[codex] fix(config): remove flat results remote alias#1562
christso merged 2 commits into
mainfrom
results-remote-schema

Conversation

@christso

@christso christso commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Reject flat results.remote in persisted config parsing/validation instead of treating it as a local Git remote-name alias.
  • Hard-deprecate legacy projects[].results.remote: registry loading ignores the whole results block when that removed field is present, and registry saving never serializes it.
  • Update docs and stale examples to use nested results.repo.remote as the endpoint URL, omit persistent require_push, and omit default push_conflict_policy.

Migration and compatibility

  • Move old same-repo config from flat results.repo_path/results.branch plus results.remote: origin to results.repo.path, results.repo.branch, and an endpoint URL in results.repo.remote when portability is needed.
  • Do not configure a local alias in persisted config. Existing checkouts may still use their configured origin internally for fetch/push.
  • results.sync.require_push remains a per-run CLI concern via --results-require-push, not persistent config.
  • Existing project registry entries containing flat results.remote now load without a results repo configuration for that project until the config is manually corrected. This is intentional hard deprecation for an unreleased/PR surface rather than a warning-period migration.

Validation

  • bun test packages/core/test/evaluation/loaders/config-loader.test.ts
  • bun test packages/core/test/evaluation/validation/config-validator.test.ts
  • bun test packages/core/test/projects.test.ts
  • bun test apps/cli/test/commands/results/remote-auto-export.test.ts
  • bun --filter @agentv/core typecheck
  • bun --filter @agentv/core build
  • bun --filter agentv typecheck
  • bun --filter agentv build
  • bun run typecheck:workspace
  • bun run lint
  • bun run validate:examples

Follow-up hard-deprecation validation also reran project registry, loader, and validator tests, bun --filter @agentv/core typecheck, and bun run lint.

Refs av-6t2e

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 29, 2026

Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 528eb56
Status: ✅  Deploy successful!
Preview URL: https://0865018f.agentv.pages.dev
Branch Preview URL: https://results-remote-schema.agentv.pages.dev

View logs

@christso christso marked this pull request as ready for review June 29, 2026 06:17
@christso christso merged commit 278f0db into main Jun 29, 2026
8 checks passed
@christso christso deleted the results-remote-schema branch June 29, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant