[codex] fix(config): remove flat results remote alias#1562
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
528eb56
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0865018f.agentv.pages.dev |
| Branch Preview URL: | https://results-remote-schema.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
results.remotein persisted config parsing/validation instead of treating it as a local Git remote-name alias.projects[].results.remote: registry loading ignores the whole results block when that removed field is present, and registry saving never serializes it.results.repo.remoteas the endpoint URL, omit persistentrequire_push, and omit defaultpush_conflict_policy.Migration and compatibility
results.repo_path/results.branchplusresults.remote: origintoresults.repo.path,results.repo.branch, and an endpoint URL inresults.repo.remotewhen portability is needed.origininternally for fetch/push.results.sync.require_pushremains a per-run CLI concern via--results-require-push, not persistent config.results.remotenow load without a results repo configuration for that project until the config is manually corrected. This is intentional hard deprecation for an unreleased/PR surface rather than a warning-period migration.Validation
bun test packages/core/test/evaluation/loaders/config-loader.test.tsbun test packages/core/test/evaluation/validation/config-validator.test.tsbun test packages/core/test/projects.test.tsbun test apps/cli/test/commands/results/remote-auto-export.test.tsbun --filter @agentv/core typecheckbun --filter @agentv/core buildbun --filter agentv typecheckbun --filter agentv buildbun run typecheck:workspacebun run lintbun run validate:examplesFollow-up hard-deprecation validation also reran project registry, loader, and validator tests,
bun --filter @agentv/core typecheck, andbun run lint.Refs av-6t2e