fix(eval): move local workspace binding out of eval YAML#1549
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
ceb9e77
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6c7c0fc.agentv.pages.dev |
| Branch Preview URL: | https://schema-av-rta-local-workspac.agentv.pages.dev |
104b03d to
a3474d1
Compare
a3474d1 to
ceb9e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Committed eval YAML now describes only portable workspace intent. Authored eval files reject machine-local workspace bindings and runtime workspace blocks in eval YAML, with migration guidance toward
--workspace-pathor.agentv/config.local.yaml.Runtime local workspace binding still works outside eval YAML: CLI
--workspace-pathcontinues to imply static runtime mode, and.agentv/config.local.yamlcan supply local workspace path/mode defaults. Committed.agentv/config.yamlignores those local-only keys with warnings.Docs, ADRs, examples, generated schema references, and agent authoring skills now teach
workspace.isolation: shared | per_casefor folder isolation and keep Docker as environment/container config rather than a folder-isolation name.Behavior Change
template,repos,hooks,env,docker, andisolation--workspace-pathor.agentv/config.local.yamlonly--workspace-mode tempor local configReview Resolution
A final read-only review found one P1 gap: per-test runtime workspace blocks passed validation and were silently ignored by the YAML parser. Commit
ceb9e774fixes that path across schema validation, CLI validation, direct YAML loading, generated schema references, and regression tests.Validation
mainafter PR fix(eval): tighten workspace composition contracts #1547 landed as9022d87b.bun test packages/core/test/evaluation/repo-schema-validation.test.ts packages/core/test/evaluation/workspace-config-parsing.test.ts packages/core/test/evaluation/validation/eval-validator.test.ts packages/core/test/evaluation/loaders/config-loader.test.ts packages/core/test/evaluation/orchestrator.test.ts packages/core/test/evaluation/eval-inline-experiment.test.ts packages/core/test/evaluation/validation/eval-schema-sync.test.ts— 327 passbun test packages/core/test/evaluation/validation/eval-schema-sync.test.ts— pass after formatting generated schemabun run lint— passbun run typecheck— passgit diff --check— pass@agentv/coretests, lint, typecheck, and read-only review; one config-local-only leak was found before commit and fixed.