Skip to content

fix(eval): move local workspace binding out of eval YAML#1549

Merged
christso merged 1 commit into
mainfrom
schema/av-rta-local-workspace-binding
Jun 28, 2026
Merged

fix(eval): move local workspace binding out of eval YAML#1549
christso merged 1 commit into
mainfrom
schema/av-rta-local-workspace-binding

Conversation

@christso

@christso christso commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Committed eval YAML now describes only portable workspace intent. Authored eval files reject machine-local workspace bindings and runtime workspace blocks in eval YAML, with migration guidance toward --workspace-path or .agentv/config.local.yaml.

Runtime local workspace binding still works outside eval YAML: CLI --workspace-path continues to imply static runtime mode, and .agentv/config.local.yaml can supply local workspace path/mode defaults. Committed .agentv/config.yaml ignores those local-only keys with warnings.

Docs, ADRs, examples, generated schema references, and agent authoring skills now teach workspace.isolation: shared | per_case for folder isolation and keep Docker as environment/container config rather than a folder-isolation name.

Behavior Change

Before After
Eval YAML could carry local workspace path/mode as runtime setup Eval YAML rejects local workspace binding fields; use portable template, repos, hooks, env, docker, and isolation
Runtime workspace blocks could be authored in eval YAML Runtime workspace binding moves to CLI flags or local config
Local path binding could be encoded in authored evals Existing local directories bind via --workspace-path or .agentv/config.local.yaml only
Shared repo workspace pooling could be authored as an explicit mode Shared repo workspaces pool by default; local fresh runs use runtime --workspace-mode temp or local config

Review Resolution

A final read-only review found one P1 gap: per-test runtime workspace blocks passed validation and were silently ignored by the YAML parser. Commit ceb9e774 fixes that path across schema validation, CLI validation, direct YAML loading, generated schema references, and regression tests.

Validation

  • Rebased onto main after PR fix(eval): tighten workspace composition contracts #1547 landed as 9022d87b.
  • bun test packages/core/test/evaluation/repo-schema-validation.test.ts packages/core/test/evaluation/workspace-config-parsing.test.ts packages/core/test/evaluation/validation/eval-validator.test.ts packages/core/test/evaluation/loaders/config-loader.test.ts packages/core/test/evaluation/orchestrator.test.ts packages/core/test/evaluation/eval-inline-experiment.test.ts packages/core/test/evaluation/validation/eval-schema-sync.test.ts — 327 pass
  • bun test packages/core/test/evaluation/validation/eval-schema-sync.test.ts — pass after formatting generated schema
  • bun run lint — pass
  • bun run typecheck — pass
  • git diff --check — pass
  • Earlier worker validation before rebase also ran schema generation, CLI eval integration, prepare/bundle command tests, full @agentv/core tests, lint, typecheck, and read-only review; one config-local-only leak was found before commit and fixed.

Compound Engineering
GPT-5

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 28, 2026

Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: ceb9e77
Status: ✅  Deploy successful!
Preview URL: https://c6c7c0fc.agentv.pages.dev
Branch Preview URL: https://schema-av-rta-local-workspac.agentv.pages.dev

View logs

Base automatically changed from implement-composition-dx-beads to main June 28, 2026 01:06
@christso christso force-pushed the schema/av-rta-local-workspace-binding branch from 104b03d to a3474d1 Compare June 28, 2026 01:17
@christso christso force-pushed the schema/av-rta-local-workspace-binding branch from a3474d1 to ceb9e77 Compare June 28, 2026 01:31
@christso christso marked this pull request as ready for review June 28, 2026 01:38
@christso christso merged commit d546e78 into main Jun 28, 2026
8 checks passed
@christso christso deleted the schema/av-rta-local-workspace-binding branch June 28, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant