docs(results): codify eval result identity contract#1539
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
da48f18
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56cdeb06.agentv.pages.dev |
| Branch Preview URL: | https://docs-contract-after-result-d.agentv.pages.dev |
christso
commented
Jun 27, 2026
christso
left a comment
Collaborator
Author
There was a problem hiding this comment.
Findings:
- P2 docs terminology drift:
apps/web/src/content/docs/docs/evaluation/running-evals.mdx:113still describes the generated task bundle as living inside a "per-test artifact directory", andapps/web/src/content/docs/docs/evaluation/running-evals.mdx:363says the wizard remembers the last run's "artifact directory". This PR is codifyingresult_diras the opaque per-row allocation and the run directory as the resume/output boundary, while avoidingartifact_diras the public term. These two public-doc phrases keep teaching workers to use "artifact directory" for exactly the directories the new contract is trying to name as result/run directories. Suggested fix: change line 113 to "per-test result directory" or "result directory", and line 363 to "last run directory".
Verification performed:
- Fetched current main and PR head with the provided fallback refs (
origin/main,refs/remotes/pr/1539), without rewriting remotes. - Reviewed diff against
origin/mainforCONCEPTS.md,running-evals.mdx, ADR 0006, and ADR 0009. - Checked against
AGENTS.md,STRATEGY.md,ROADMAP.md,.agents/product-boundary.md,.agents/workflow.md, and.agents/verification.md. - Ran
git diff --check origin/main..refs/remotes/pr/1539. - Ran
git grep -n "artifact_dir" refs/remotes/pr/1539 -- CONCEPTS.md apps/web/src/content/docs/docs/evaluation/running-evals.mdx docs/adr/0009-eval-path-result-identity-and-default-experiment.md docs/adr/0006-separate-experiments-from-eval-definitions.mdand found no exactartifact_dirmatches in the changed docs. - Checked GitHub Actions for PR #1539: Build, Typecheck, Lint, Test, Check Links, Validate Evals, Validate Marketplace, and Cloudflare Pages are passing.
Verdict: Ready with a small docs terminology fix; not merging while the finding is unresolved.
Collaborator
Author
|
Unblocked: PR #1540 / av-504.2 has merged into Please refresh/rebase this branch against current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency
This PR documents the final
result_dirfield name and should land after the av-504.2 result_dir rename branch/PR. No code changes are included.Verification
bun installbun --filter @agentv/web buildgit diff --checkgit diff --cached --checkrg -n "artifact_dir" CONCEPTS.md apps/web/src/content/docs/docs/evaluation/running-evals.mdx docs/adr/0009-eval-path-result-identity-and-default-experiment.md(no matches)Biome note:
bunx biome check <changed md/mdx files>reports no files processed because Markdown/MDX are outside the configured Biome scope.