fix(results): disambiguate target artifact directories#1538
Closed
christso wants to merge 1 commit into
Closed
Conversation
Deploying agentv with
|
| Latest commit: |
bba2f02
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://31ba75e1.agentv.pages.dev |
| Branch Preview URL: | https://fix-av-9919-target-artifact.agentv.pages.dev |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multi-target runs that reuse the same suite and test ID now write separate physical artifact directories instead of overwriting the same
run-1folder. Single-target paths keep the existingsuite/test/run-Nortest/run-Nlayout, andindex.jsonlremains the authoritative source for every emitted path.Validation
bun test apps/cli/test/commands/eval/artifact-writer.test.ts --test-name-pattern "allocates distinct artifact directories"failed with both rows pointing atsuite-a/shared-id.bun test apps/cli/test/commands/eval/artifact-writer.test.ts,bun test apps/cli/test/commands/eval/aggregate.test.ts,bun test packages/core/test/evaluation/orchestrator.test.ts.bun --filter @agentv/core typecheck,bun --filter agentv typecheck,bunx biome check packages/core/src/evaluation/run-artifacts.ts apps/cli/test/commands/eval/artifact-writer.test.ts,git diff --check.bun apps/cli/src/cli.ts eval run /tmp/agentv-av9919-live-Uxi4Gm/target-artifact-allocation.eval.yaml --targets /tmp/agentv-av9919-live-Uxi4Gm/targets.yaml --target baseline --target candidate --workers 1 --output /tmp/agentv-av9919-live-Uxi4Gm/resultspassed 2/2 with real OpenAI-backed targets and LLM grading. The manifest recordedshared-id/baselineandshared-id/candidateartifact dirs.