Component dependency ordering#3
Merged
Merged
Conversation
Signed by: Russell Seymour <russell.seymour@turtlesystems.co.uk>
Signed by: Russell Seymour <russell.seymour@turtlesystems.co.uk>
… correct order when analysed Signed by: Russell Seymour <russell.seymour@turtlesystems.co.uk>
Signed by: Russell Seymour <russell.seymour@turtlesystems.co.uk>
Signed by: Russell Seymour <russell.seymour@turtlesystems.co.uk>
Signed by: Russell Seymour <russell.seymour@turtlesystems.co.uk>
Signed by: Russell Seymour <russell.seymour@turtlesystems.co.uk>
Signed by: Russell Seymour <russell.seymour@turtlesystems.co.uk>
|
No description provided. |
RichardSlater
suggested changes
Nov 24, 2025
RichardSlater
left a comment
There was a problem hiding this comment.
Predominantly need tests to cover happy and unhappy path, also some mild inefficiency / cartesian bomb.
Added tests for the ordering of projects Moved ordering of the projects Signed by: Russell Seymour <russell.seymour@turtlesystems.co.uk>
|
No description provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Add Project Order Support and Migrate to Eirctl
📲 What
This PR implements the following changes:
orderfield to project configuration that allows projects to be executed in a specific sequence when affected by changesorderfeature and added comprehensive Copilot instructions for the project🤔 Why
Project Order Feature
In monorepo scenarios, projects often have dependencies on each other. For example, infrastructure resources (like Terraform state storage) need to be deployed before other infrastructure components. Without execution ordering, there's no guarantee that projects will build in the correct sequence, potentially causing build failures when dependencies aren't met.
Eirctl Migration
The migration from Taskctl to Eirctl aligns the project with organizational standards and provides better build tooling consistency across Ensono Stacks projects.
🛠 How
Project Order Implementation
Order intfield to theProjectstruct ininternal/config/project.goOrder intfield to theSpawnBuildmodel ininternal/models/spawn_build.gointernal/affected/affected.goto:sortpackageOrderfield when creatingSpawnBuildinstancesOrder(ascending) before execution usingsort.Slice()orderattribute (defaults to 0 if not specified)Eirctl Migration
taskctl.yaml→eirctl.yamlbuild/taskctl/→build/eirctl/build/eirctl/contexts.yamlfor environment-specific settingsinstall-eirctlaction instead ofinstall-taskctlInvoke-Compile.ps1,Invoke-IntegrationTests.ps1) to calleirctlcommandsDocumentation
docs/usage.adocto document theorderattribute in the configuration file settings tableorderusage (tfstate with order: 0, ancillary with order: 1).github/copilot-instructions.mdwith comprehensive project documentation for AI-assisted development👀 Evidence
Files Changed: 16 files modified
affected.go,project.go,spawn_build.gousage.adoc,copilot-instructions.mdeirctl.yaml, GitHub Actions workflowKey Commits:
db19f56- Added order property to projectsf7032a9- Migrated from Taskctl to Eirctl5b02d19- Updated docs and added Copilot instructions🕵️ How to test
Testing the Order Feature
Testing Eirctl Migration
Testing Documentation
docs/usage.adocto ensure theorderfield is properly documented.github/copilot-instructions.mdfor completeness and accuracy