Enhanc/examples - #44
Merged
Merged
Conversation
JulStraus
force-pushed
the
enhanc/examples
branch
from
August 20, 2025 08:14
11ad406 to
1f9a3e6
Compare
hellemo
approved these changes
Sep 22, 2025
hellemo
left a comment
hellemo
left a comment
Member
There was a problem hiding this comment.
Looks nice, and easier to follow, I think. I added some additional suggestions to improve clarity.
One issue I had was that when I tried running the examples, it failed, but it turned out I had and old Manifest.toml in the examples directory that created the problem.
JulStraus
commented
Sep 22, 2025
JulStraus
left a comment
JulStraus
left a comment
Member
Author
There was a problem hiding this comment.
Thanks a lot for your comments. I will include them in a new commit.
hellemo
reviewed
Sep 22, 2025
hellemo
reviewed
Sep 22, 2025
This was referenced Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing examples were a bit complex to understand with respect to the function flow. This rework simplifies the understanding of the examples through making them similar to the examples in the other packages.