Skip to content

Updated docs and README.md - #4

Merged
JulStraus merged 3 commits into
mainfrom
enhanc/README_docs
Dec 18, 2025
Merged

Updated docs and README.md#4
JulStraus merged 3 commits into
mainfrom
enhanc/README_docs

Conversation

@JulStraus

Copy link
Copy Markdown
Member

I just realized that we still had some parts in it related to the non-registered version. This was adjusted in this PR.

In addition, I decided to be clearer regarding the test cases, i.e., what they test and what not.

@JulStraus

Copy link
Copy Markdown
Member Author

These fails in the tests are interesting as I have not really done any changes to these checks.

I will investigate it and come back to you.

@JulStraus
JulStraus marked this pull request as draft December 16, 2025 07:34
@JulStraus

Copy link
Copy Markdown
Member Author

The problem is in the changes of PR #43 of EMG. The current implemented changes do not work as we return a single ExtensionData, i.e., the reference to the supertype. So I would honestly prefer to fix it within EMG.

@JulStraus
JulStraus marked this pull request as ready for review December 16, 2025 11:48
@JulStraus

Copy link
Copy Markdown
Member Author

The problem stems from changes in the ExtensionData design introduced in EnergyModelsBase v0.9.1 and the corresponding adjustment in EnergyModelsGeography v0.11.3.

I deactivated the tests in this version now as we want to get a good approach in these packages. These changes can take time to develop.

@lfbernardino lfbernardino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look mostly ok, I just made some typo fixes on top of your commits.

I suggest that you create an issue within EMC, such that we don't forget to reactivate the tests once the behavior is fixed within EnergyModelsBase and EnergyModelsGeography.

@JulStraus
JulStraus merged commit 079d9b3 into main Dec 18, 2025
5 checks passed
@JulStraus
JulStraus deleted the enhanc/README_docs branch December 18, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants