Repository navigation
fix: commit the MiLink native module sources - #3
Merged
Merged
Conversation
The mobile .gitignore's unanchored android/ and ios/ patterns, meant for the generated native projects, also matched modules/milink/android and modules/milink/ios. The module's Swift and Kotlin code never reached the repo, so CI builds shipped without it and the apps crashed at launch with "Cannot find native module 'MiLink'". Anchors the patterns to the app root, adds the module sources, and makes CI fail if the module isn't linked into the APK or the iOS app. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.1.0's Android and iOS apps crash at launch with
Cannot find native module 'MiLink'(reproduced on an iPhone 16 Pro Max running iOS 27.0.1).Cause: the mobile
.gitignorehad unanchoredandroid/andios/patterns (meant for the foldersexpo prebuildgenerates). They also matchedmodules/milink/androidandmodules/milink/ios, so the native module's Swift and Kotlin sources were never committed and CI built without them.Fix:
/android/and/ios/, and ignore the module's Gradle output.🤖 Generated with Claude Code