Skip to content

Fix collection modified during enumeration in package update checks #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emosaru merged 1 commit into from
Apr 13, 2026
Merged

Fix collection modified during enumeration in package update checks #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions EmoTracker.Data/Packages/PackageManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.IO;
using System.Linq;
using System.Net;

namespace EmoTracker.Data.Packages
Expand Down Expand Up @@ -269,11 +270,11 @@ public bool UpdatesAvailable
{
get
{
foreach (PackageRepository repository in Repositories)
foreach (PackageRepository repository in Repositories.ToList())
{
foreach (PackageRepositoryEntry entry in repository.Packages)
foreach (PackageRepositoryEntry entry in repository.Packages.ToList())
{
if (entry.Status == PackageRepositoryEntry.PackageStatus.UpdateAvailable)
if (entry != null && entry.Status == PackageRepositoryEntry.PackageStatus.UpdateAvailable)
return true;
}
}
Expand All @@ -286,11 +287,11 @@ public bool CurrentPackageHasUpdateAvailable
{
get
{
foreach (PackageRepository repository in Repositories)
foreach (PackageRepository repository in Repositories.ToList())
{
foreach (PackageRepositoryEntry entry in repository.Packages)
foreach (PackageRepositoryEntry entry in repository.Packages.ToList())
{
if (entry.Status == PackageRepositoryEntry.PackageStatus.UpdateAvailable)
if (entry != null && entry.Status == PackageRepositoryEntry.PackageStatus.UpdateAvailable)
{
if (entry.ExistingPackage == Tracker.Instance.ActiveGamePackage)
return true;
Expand Down
Loading