Fix capture grid dismissed by map popup light-dismiss - #43
Merged
Conversation
The tunneling PointerPressed handler that closes the location details popup on outside clicks was also closing it when clicking inside child popups (e.g. the capture grid). Popup content renders on an overlay layer with a disconnected visual tree, so the walk from e.Source never reached LocationDetailsContent for nested popups. Fix: detect clicks inside popup overlays by checking whether the visual root of e.Source is the TopLevel window. If not, the click is inside a popup overlay and should not dismiss the location details. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Popup content in Avalonia renders on an overlay layer with a disconnected visual tree. The light-dismiss handler walked up from
e.Sourcelooking forLocationDetailsContent, but for nested popups (capture grid inside location details), the walk terminates at the overlay host without ever reachingLocationDetailsContent. The handler incorrectly treated this as an "outside" click.Test plan
🤖 Generated with Claude Code