Fix input handling and map popup light-dismiss - #39
Merged
Conversation
…t, and popup light-dismiss TrackableItemControl now uses a standard Image (rectangular hit test) by default and only uses InputMaskingImage (per-pixel alpha) when MaskInput is true. IgnoreUserInput is enforced via IsHitTestVisible binding, CanExecute checks, and an early guard in Grid_PointerReleased. LocationMapControl popup dismiss now uses a tunneling PointerPressed handler on the top-level window so clicks on controls outside the map (e.g. tracker items) properly close the location details popup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Image(rectangular hit test) by default, only switching toInputMaskingImage(per-pixel alpha hit test) whenMaskInputis trueIsHitTestVisiblebinding on the outer Grid,CanExecutechecks on both left/right click commands, and an early guard inGrid_PointerReleasedPointerPressedhandler on the top-level window, fixing the issue where clicking items outside the map wouldn't dismiss the popupTest plan
IgnoreUserInput=truecannot be clicked (left or right)🤖 Generated with Claude Code