Tidy up client creation - #287
Merged
Merged
Conversation
Feels a little backwards to be passing builders to the client object but it's the best solution I can come up with that doesn't involve making the objects movable (opens up multiple cans of worms) or allocating them (more indirections, worse locality for message handling). Could tidy it up further by binding the additional arguments to the create functions and passing those to the client builder but that'd introduce its own overhead and is probably over the top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feels a little backwards to be passing builders to the client object but it's the best solution I can come up with that doesn't involve making the objects movable (opens up multiple cans of worms) or allocating them (more indirections, worse locality for message handling). Could tidy it up further by binding the additional arguments to the create functions and passing those to the client builder but that'd introduce its own overhead and is probably over the top.