Styled v5 - #9
Open
itsjoekent wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Hm, seems like this broke some stuff, FAIL src/hooks/useBreakpoint/useBreakpoint.test.js
● Test suite failed to run
Could neither find styled-components secret internals nor styled-components/lib/models/StyleSheet.js
1 | import Adapter from 'enzyme-adapter-react-16';
2 | import { configure } from 'enzyme';
> 3 | import 'jest-styled-components'; |
|
Hmm that failing test is odd. It's generating a lot f empty media queries. I can reproduce locally. It seems like a bug in the library. |
jjandoc
suggested changes
Jun 8, 2020
jjandoc
left a comment
jjandoc
left a comment
There was a problem hiding this comment.
Leaving a code review so this PR gets off my queue. 😭
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
styled-components v5 was released a week ago and introduced a number of performance improvements, and thankfully, there was no breaking API changes introduced!
https://styled-components.com/releases#v5.0.0
https://styled-components.com/docs/faqs#what-do-i-need-to-do-to-migrate-to-v5