fix(EC-22843): strict whitespace enforcement - #128
Merged
Conversation
TimEvink
marked this pull request as ready for review
July 22, 2025 12:02
TimEvink
requested review from
a user,
artlitv,
dilan-adel,
kodeInInk,
minardus,
priyaelf,
reneoun and
yasinghasmi
July 22, 2025 12:02
kodeInInk
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, a dependency of https://github.com/Elfsquad/cpq/pull/7086, enforces the following whitespace formatting of the sentences in the translations csv's.
More specifically, this PR adds a workflow (check-whitespace.yml) that runs a test (test-whitespace.py) on every pr to main of translations, passing only if the above two rules are met for all the text in the translations file.
The translations csv's are also updated to conform to this new test, and a helper script is included which I used to generate the new csv's (and could be helpful in case of manual intervention later on).
Finally some small changes to existing scripts/workflows: