feat(EL-826): add file field to ConfigurationFeature - #37
Merged
Conversation
mariusz-peplinski
force-pushed
the
feat/EL-826-configuration-feature-file
branch
from
June 29, 2026 11:42
a2ab7ea to
befeb2e
Compare
Adds a ConfigurationFeatureFile type ({ url, name }) and an optional
file?: ConfigurationFeatureFile field on ConfigurationFeature, mirroring
the configurator API's FileValue. This lets consumers (Showroom v2) read
the uploaded file for File-type features (FeatureType.File) to render a
download link, matching legacy Showroom v1 behaviour.
mariusz-peplinski
force-pushed
the
feat/EL-826-configuration-feature-file
branch
from
June 29, 2026 11:56
befeb2e to
cfd3e17
Compare
mariusz-peplinski
marked this pull request as ready for review
June 29, 2026 12:01
p-bartosz
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for reading the file uploaded to a File-type configurator feature (
FeatureType.File, value5).ConfigurationFeatureFiletype —{ url: string; name: string }— mirroring the configurator API'sFileValueDTO.file?: ConfigurationFeatureFilefield onConfigurationFeature.ConfigurationFeatureFilefrom the package entrypoint.The configurator API already returns this object on the feature when a file is present; the SDK type just didn't expose it. No runtime/behavioural change — type-only addition.
Why
Part of EL-826 — File feature type does not show file attachment component in Showroom v2. Showroom v2 needs the
filefield to render the download link + delete control for already-uploaded files, matching legacy Showroom v1.Multi-repo
This is the first / prerequisite of two interdependent PRs:
Elfsquad/configurator— expose thefilefield. Merge + release first.Elfsquad/showroom— implement the File feature UI/upload/remove; will consume this field once released and the dependency is bumped.Test impact
Type-only change;
npm run buildpasses. No new tests.