chore(EL-1547): set the package version to 3.1.1 so the release can publish - #33
Merged
Merged
Conversation
…ctually publish to npm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA TASK: EL-1547 - Clean up showroom developer console logs and warnings
📦 The 3.1.0 release never reached npm
3.1.0was tagged and a GitHub release was cut, butPublish to NPMfailed (run 32855740962):The release tag pointed at a commit whose
package.jsonstill said3.0.0, sonpm publishtried to republish the existing version and npm rejected it. npm latest is still3.0.0, which means the quiet-OAuth-logs work in #31 has not reached any consumer.WHAT
One line:
package.jsonversion→3.1.1.WHY 3.1.1 AND NOT 3.1.0
Going to a fresh patch avoids deleting and re-cutting the existing
3.1.0tag and release. Nothing was ever published as3.1.0, so no consumer can be holding it, and npm does not require contiguous versions —3.0.0 → 3.1.1publishes cleanly.The dud
3.1.0GitHub release is left in place; it can be deleted separately if you'd rather not have a release with no npm artifact behind it.HOW TO RELEASE
3.1.1release.Publish to NPMshould now succeed.npm view @elfsquad/authentication version→3.1.1.VERIFICATION
npm run build— compiles clean.npm test— 63/63 pass.main, confirmed by re-running it against3.0.0).FOOTNOTES / CAVEATS
@elfsquad/configuratorbundles its own inlined copy of this package — the OAuth classes and this package's log strings are compiled intoconfigurator/dist/index.js. So bumping a consumer's direct dependency on@elfsquad/authenticationis not enough to quiet the logs that come through configurator; configurator needs a rebuild and release of its own. That is follow-up work, not this PR.