task ready#31
Open
sergeywhite86 wants to merge 4 commits into
Open
Conversation
Miqelad
reviewed
Sep 16, 2025
|
|
||
| @Override | ||
| @PostMapping("/login") | ||
| public Map<String, String> login(@Valid @RequestBody AuthRequest request) { |
Contributor
There was a problem hiding this comment.
Вместо Map.of("token", token) лучше вернуть DTO (AuthResponse)
Причины:
Явный контракт API (видно, какие поля есть в ответе)
Легче расширять (например, добавить refreshToken, expiresIn)
| @PreAuthorize("hasRole('ADMIN')") | ||
| @GetMapping | ||
| public List<TodoDto> getAllTodos(@RequestParam(defaultValue = "10") | ||
| int limit, @RequestParam(defaultValue = "0") int offset) { |
Contributor
There was a problem hiding this comment.
limit/offset создают впечатление пагинации, но на самом деле мы не возвращаем total, hasNextPage и т.п. Лучше использовать DTO с метаинформацией (PageResponse).
Naming: getMyTodos не очень REST-friendly. Стоит переименовать в getCurrentUserTodos или getUserTodos
Ниже так же, и поправь naming RESTful api
| - changeSet: | ||
| id: 1 | ||
| author: sergey_white | ||
| changes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
файл .env добавил для запуска приложения