Created Spring ToDo basic version#30
Open
vladimirchavkin wants to merge 11 commits into
Open
Conversation
Miqelad
reviewed
Oct 13, 2025
| import org.springframework.http.ResponseEntity; | ||
|
|
||
| @Tag(name = "Task Controller", description = "Контроллер для работы с задачами.") | ||
| public interface SwaggerTaskController { |
Contributor
There was a problem hiding this comment.
Его не имплементирует контроллер
| @@ -0,0 +1,22 @@ | |||
| CREATE TABLE tasks | |||
| ( | |||
Contributor
There was a problem hiding this comment.
Предусловия напиши preconditions существует ли база
| } | ||
|
|
||
| @Test | ||
| void createTask_Success_ReturnsCreatedTask() throws Exception { |
Contributor
There was a problem hiding this comment.
Условия ТЗ в README не выполнены
Тестирование:
Покрыть приложение юнит и интеграционными тестами.
Интеграционные тесты для всех контроллеров через JSON Assert.
Настроить тестовую БД через Testcontainers.
Применять @SQL для подготовки данных.
Все тесты снабдить @DisplayName для читаемости логов.
fix: - TaskController now implements SwaggerTaskController; refactor: - ApiResponse renamed to CustomResponse to avoid conflict with swagger.ApiResponse in SwaggerTaskController; - V1__CREATE_TASKS_TABLE.sql now creates table IF NOT EXISTS; - Tests now documented by @DisplayName annotation; test: - Added TaskControllerIntegrationTest;
features: - Added TaskRepositoryValidator; fix: - ExceptionMessage now it has correct messages. refactor: - TaskRepositoryImpl -> JdbcTaskRepository; - Task now Entity. - TaskServiceImpl and TaskServiceImplTest now use HibernateTaskRepository instead JdbcTaskRepository; test: - Added HibernateTaskRepositoryTest;
features: - Added JpaTaskRepository; refactor: TaskServiceImpl now use JpaTaskRepository; test: - Added JpaTaskRepositoryTest;
# Conflicts: # Jenkinsfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.