Add option for pretension only in Sport mode

[SAMUD]

Introduces USE_PRETENSION_ONLY_IN_SPORT_MODE to restrict pretensioning to Sport mode. Updates logic in apply_pretension to check operation mode, improving compliance for EU riding scenarios.

[Eelviny]

I like the idea of this feature, and I do want to add it. However, I've been trying to actively get rid of config values that are "global" or specific to one mode type, instead preferring to explicitly specify this for each assist level. 2 reasons:

• I might support many arbitrary modes as "profiles" in the future, not just standard/sport, so this would not work there
• The future CLI config tool will handle all the messy, complicated per-assist-level settings with sane defaults.

Would you be up for re-implementing this but instead allow for pretension to be set for each individual assist level? Then in your config, you can enable it for just the sport levels.

[Eelviny]

If not, I'll find time to have a go at it next week maybe

[SAMUD]

Hi, Yeah sounds like an Idea to do it like you proposed. My PR is just how I added it to my config this weekend when I was playing around with your firmware.

I can try to change it, but it might take some time if I want to test it before on my bike. I destroyed my fork yesterday jumping over a tree stump fully loaded with a big backpack 😅 So i first need to sort out the fork-bug 😅

[Eelviny]

Ah that sucks :( Tree stump 1, @SAMUD 0. Out of curiosity and also so I know what else bbsxtra is compatible on, what bike and motor are you rocking?

And no worries on that, when you've got a min throw some code into the PR, and it can sit until either one of us has a minute to test it. I've not tried out the pretension feature before so it would be a good excuse to do so.

[Eelviny]

And one more note, I really appreciate you contributing! I've been keeping this project a little bit under the radar until I've done the user-friendly stuff like writings docs and making the config tool, so it's nice to have another person giving the firmware a spin in these early stages.

[SAMUD]

Oh... I am running an old bike. A Scott Genius 40 with a BBSHD and a custom build 14S5P 21700 Battery (link) with approximately 1,2kwh.

I especially wanted to have one of the older UART BBSHD Motors, because of the custom firmware and the special "sport" mode if you are driving on your own private property ;) I don't know from where you are, but here in Germany the police is really paying attention to tuned e-bikes and scooters.
And Its really a pain in the ass.... Legally for custom builds you are only allowed for 250W. But If you buy a DJI Avinox, which is also legal you have 1kw of power.

And one more note, I really appreciate you contributing! I've been keeping this project a little bit under the radar until I've done the user-friendly stuff like writings docs and making the config tool, so it's nice to have another person giving the firmware a spin in these early stages.

Yeah its not so user friendly right now, but with a little bit of IT knowledge and try and error I got it running with the config file :)

[Eelviny]

Nice battery case, looks slick :)

From the Netherlands here, the police are paying attention but the majority of that attention goes to fatbikes. I'm tuning & testing bbsxtra with EU street-legal settings in mind, but at the end of the day you can never be 100% legal when the motor you're using is not 250W rated, even though we know how arbitrary that restriction is.