Repository navigation
fix: retain plate-clear presses after request failures - #43
Merged
Merged
Conversation
Owner
Author
|
Compatibility issues fixed in b3a6809. The AP retry timestamp is now initialized after the startup block, so PR #43 composes with #42's config-readiness startup gate. The test fixture also exposes the readiness API used by that combined candidate. Validation: 22 focused plate-clear/API/Wi-Fi tests pass; the combined candidate passes 125 tests excluding the two GUI modules that need the unavailable local FreeSimpleGUI dependency. Flake8 and compilation pass. PR #45 CI is green; its checks will apply to main after #45 lands. Still needs hardware evidence: simulate a dropped/lost response and verify the press remains pending, then rehearse Wi-Fi/AP recovery on ESP32-C3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39. Preserve the button intent after API failures, reconcile ambiguous outcomes against printer status before retrying, keep the plate-clear LED active while pending, and retry station Wi-Fi from setup AP mode.
The AP retry timestamp is initialized outside the connection call so this change composes cleanly with the startup config-readiness gate. Test doubles include that readiness API for the combined candidate.
Validation: 22 focused tests passed; touched-file compilation and git diff --check passed. Hardware validation remains outstanding.