chore: check AGENTS.md path claims in both directions - #115
Merged
Conversation
A backticked path must exist - unless the sentence says it does not, in which case it must NOT exist. That second direction is the one this org needs. The AGENTS.md files now name dead paths deliberately, so nobody mistakes retired directories for live code: EduIDE points at four retired image trees, EduIDE-Cloud says java/pom.xml does not exist and explains why that means the Dockerfiles are the build. If someone later creates one of those, the doc has quietly become wrong again and the one-directional check would say nothing. Only true absence flips the check. "is dead", "retired" and "never built" describe something that exists and does not work, which is a different claim - scorpio_auto_update.yml is exactly that, and conflating the two made the guard demand its deletion. Verified by creating a path the doc says is absent and watching it fail.
|
Warning Review limit reachedNext included review available in 35 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A backticked path must exist — unless the sentence says it does not, in which case it must not.
The second direction is the one this org needs. The rewritten AGENTS.md files deliberately name dead paths so nobody mistakes retired directories for live code — EduIDE points at four retired image trees, EduIDE-Cloud states that
java/pom.xmldoes not exist and explains why that means the Dockerfiles are the build order. If someone later creates one of those, the doc is quietly wrong again and a one-directional check says nothing.Only true absence flips the check. "is dead", "retired" and "never built" describe something that exists and does not work — a different claim. Conflating them made the guard demand the deletion of a workflow that exists and is simply broken.
Verified by creating a path the doc says is absent and watching it fail.
The same script lands in EduIDE, EduIDE-Cloud, EduIDE-Landing-Page and theia-scale-tests alongside their AGENTS.md rewrites.