getConcordances includes XML:IDs of concordances, groups and connections or generates a stable ID for them - #210
Conversation
|
I modfied this PR: |
peterstadler
left a comment
There was a problem hiding this comment.
The code looks really good and I agree that this can be merged without breaking backwards compatibility.
Yet the test are failing (as expected) so you should update the test files (the expected results) within this PR.
peterstadler
left a comment
There was a problem hiding this comment.
Looks good, and tests are successful 👍
Description, Context and related Issue
Refs #209
Includes the
xml:idofconnectionelements in the objects. This makes it possible to navigate to a certain connection via their ID, see Edirom/Edirom-Online-Frontend#268Now returns something like
{ "id" : "connection2", "plist" : "....", "name" : "2" }, { "id" : "connection3", "plist" : "....", "name" : "3" }How Has This Been Tested?
Tested with Edition Example and internal Korngold data.
Types of changes