fix(ci): restore build log artifact upload for Companion CI - #7654
Open
pfeerick wants to merge 5 commits into
Open
fix(ci): restore build log artifact upload for Companion CI#7654pfeerick wants to merge 5 commits into
pfeerick wants to merge 5 commits into
Conversation
PR #6435 replaced the OS-specific Companion workflows (which had always-on log collection added in #6682) with a unified build_companion composite action, but dropped the log collection/upload logic in the process. On a build or packaging failure the only diagnostic output was the truncated Actions log, with no way to retrieve the full CMake/build log. Restore the "Collect build logs" and "Archive build logs" steps (if: always()) in the composite action so a <artifact_name>-logs artifact is produced regardless of build outcome. Fixes #7451
Verifies the restored production + log artifact upload works on a successful Companion build for PR #7654.
Temporary #error to force a compile failure and confirm the Archive build logs step still uploads the -logs artifact on a failed build. Will be reverted once verified.
…pload" This reverts commit 611ece1. Failure-path CI run (31874504405) confirmed the fix: all three platform builds failed on the injected #error as expected, no production artifact was uploaded, but each build still produced its <artifact_name>-logs artifact containing the full compile error. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… path" This reverts commit 8f17e2f. Success-path CI run (31873170894) confirmed the fix: all three platform builds passed and each uploaded both its production artifact and its <artifact_name>-logs artifact. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
Validated the fix live in CI before dropping the draft status of "needs testing": Success path (run 31873170894, bumped Failure path (run 31874504405, temporary Both test commits have been reverted (kept in history rather than force-pushed away, so the CI runs above stay linked to real commits on this branch). |
pfeerick
marked this pull request as ready for review
August 15, 2026 09:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux_cpn.yml,macosx_cpn.yml,win_cpn-64.yml) with the unifiedcompanion.yml+.github/actions/build_companion/action.yml.if: always()to the filename-composition step so the artifact name is available even when the build fails.Collect build logsstep (if: always()) that gathersbuild/**/*.log,CMakeOutput.log, andCMakeError.loginto alogs/directory.Archive build logsstep (if: always()) uploadinglogs/as<artifact_name>-logswith 30-day retention, alongside the existing production-artifact upload.Since this composite action is now shared by all three platform jobs (
build-linux,build-macos,build-win64), a single change here covers all of them, unlike the original fix in #6682 which needed to be duplicated across three workflow files.Test plan
<artifact_name>-logsartifact is produced and contains the CMake/build logs.Fixes #7451
🤖 Generated with Claude Code