Login redesign integration (draft, edge-login-ui-rn#295)#6048
Draft
j0ntz wants to merge 1 commit into
Draft
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Draft integration only: pin edge-login-ui-rn to a local prebuilt tarball of the jon/login-redesign branch (EdgeApp/edge-login-ui-rn#295) so CI and a feta cheese build exercise the unified login scene before the dep is published. Not for merge.
j0ntz
force-pushed
the
jon/login-redesign
branch
from
2c5e503 to
c821b3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft integration build (do not merge)
Wires the unified login redesign from edge-login-ui-rn into edge-react-gui so CI and a
fetacheese build can exercise the new login scene before the dependency is published.edge-login-ui-rnto a local prebuilt tarball (deps/edge-login-ui-rn-3.36.0.tgz) of thejon/login-redesignbranch instead of a version bump, per the task request (tarball over git pointer because the git-pointer install does not run the dep'sprepare, solib/is missing).tsc --noEmitclean; iOS sim renders the redesigned scene and a PIN login reaches the wallet-list home.This branch is a throwaway vehicle for CI + cheese; it is not intended to merge (it pins a local tarball).
Asana: https://app.asana.com/0/1215088146871429/1215939017452141