Skip to content

Convert to npm#449

Merged
peachbits merged 4 commits into
masterfrom
convert-to-npm
Jun 12, 2026
Merged

Convert to npm#449
peachbits merged 4 commits into
masterfrom
convert-to-npm

Conversation

@peachbits

@peachbits peachbits commented May 26, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Tooling and documentation only; no runtime or library code changes in this diff.

Overview
Switches the repo from Yarn to npm as the documented and CI package manager.

Travis now runs npm run verify instead of yarn verify. .yarnrc is deleted and .npmrc adds legacy-peer-deps=true for installs. .gitignore no longer ignores package-lock.json, so the npm lockfile can be committed. README and docs/currency-integration.md tell contributors to use npm run start instead of yarn start for the Webpack dev server.

Reviewed by Cursor Bugbot for commit f789ab8. Bugbot is set up for automated code reviews on this repo. Configure here.

@peachbits peachbits changed the title Convert yarn → npm + Socket security upgrades + @edge.app fork aliases Convert to npm Jun 2, 2026
@j0ntz

j0ntz commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

CI status: Travis is red, failing at the test step of verify (prepare/lint/types pass; Bugbot is clean). Verified from the build log:

TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts"test/common/fees/calcMinerFeePerByte.spec.ts

Same root cause as EdgeApp/disklet#45 — after the npm conversion mocha isn't loading the TypeScript register, so .ts specs can't be imported. The mocha .ts loader needs wiring up.

@j0ntz

j0ntz commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Applied in 332e586. Pinned get-func-name to 2.0.2 via npm overrides. The lock had resolved the broken ESM-only get-func-name@2.0.1, which chai (CommonJS) can't require → mocha falls back to import() of the .ts specs → ERR_UNKNOWN_FILE_EXTENSION. Verified on Node 18 (matching this PR's CI): npm ci in sync + npm run verify green (1215 passing). Flagging since this is my change on your branch — please review.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Comment thread .npmrc

@j0ntz j0ntz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — review threads are settled (the remaining open thread, where present, has a pending note to answer or address before merging) and real CI is green; block-wip-pr clears once the fixups are squashed.

convert-to-npm and others added 4 commits June 10, 2026 23:29
@peachbits peachbits merged commit 0f1d175 into master Jun 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants