chore: require go 1.26 - #131
Closed
WispHes wants to merge 1 commit into
Closed
Conversation
build.yml and release.yml move off go-version 1.22.0. .golangci.yml keeps targeting 1.21.3: the pinned golangci-lint v1.64.8 is built with go 1.24 and refuses a config that targets a newer version.
Collaborator
Author
|
Closing until this repo moves to golangci-lint v2. The pinned linter, v1.64.8, is the last v1 release and is built with go 1.24. Against a module that declares go 1.26 it cannot typecheck any package at all: "package requires newer Go version go1.26 (application built with go1.24)", and the 50 errors that follow are fallout from that. No change to .golangci.yml gets around it, the go.mod directive alone is enough to break the run. So the linter upgrade has to land first, then the go 1.26 bump can come back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go 1.22.0 -> 1.26.0, to match the rest of the SDKs and the provider.
build.yml and release.yml move off go-version 1.22.0.
.golangci.yml is left alone. It targets 1.21.3, and raising it to 1.26 breaks lint outright: the golangci-lint version pinned in the Makefile, v1.64.8, is the last v1 release and is built with go 1.24, so it refuses a config that targets a newer version. Moving this repo to golangci-lint v2, the way the other SDKs already run it, is a separate change.
Checked locally: go build ./... and go test ./... pass.