Allow MP_PROJECT_CONFIG handling to support absolute paths - #57
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Django settings to support locating the portal config.ini outside the madrona-portal repo by allowing MP_PROJECT_CONFIG to be provided as an absolute path, enabling app modularity/decoupling.
Changes:
- Allow
MP_PROJECT_CONFIGto be an absolute path when resolvingCONFIG_FILE. - Keep existing relative-path behavior by joining
MP_PROJECT_CONFIGagainstBASE_DIR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+42
to
+45
| if os.path.isabs(MP_PROJECT_CONFIG): | ||
| CONFIG_FILE = MP_PROJECT_CONFIG | ||
| else: | ||
| CONFIG_FILE = os.path.normpath(os.path.join(BASE_DIR, MP_PROJECT_CONFIG)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
config.inifiles to be stored outside ofmadrona-portal. This will enable modularity of portal apps. Config files forwcoa,wcoffshore, andmida-portalcan be moved (decoupled) out ofmadrona-portaland into each app.@paigewilliams I added you as a reviewer for visibility. This PR begins the process of decoupling the data portal apps (
wcoa,mida-portal) frommadrona-portal.