Modernize plugin#3
Open
ihateblueb wants to merge 9 commits into
Open
Conversation
…lt value for message strings
Member
|
Ill review when I can. Thanks for pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits config code to a main Config class, makes most messages configurable, adds config comments, uses MiniMessage over legacy APIs, and cleans up code.
I didn't initially plan to PR this because I felt like it isn't fully sticking to the original plugin, but the license requires it. I'll gladly adjust whatever you'd like if you did want some of the improvements included in the plugin.