Skip to content

Question summary fixes #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alaninnovates wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Question summary fixes #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions app/src/screens/search-flow/QuestionSummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {useEffect} from 'react';
import React, {useEffect, useMemo} from 'react';
import {View, Text, Button, Pressable} from 'react-native';
import {useTheme} from '@react-navigation/native';
import {useState} from 'react';
Expand Down Expand Up @@ -35,6 +35,17 @@ function QuestionSummary({item, index, data, generate_ai_summary}: Props) {
const [stats, setStats] = useState<Statistics | null>(null);
const [modalActive, setModalActive] = useState<boolean>(false);

const processedData = useMemo(

@Versus7 Versus7 Apr 11, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a system where you average duplicate data points would be safer for the data, since we don't know which individual report was the most accurate.

() =>
data
.sort((a, b) => a.match - b.match)
.filter(
(datum, index, self) =>
index === self.findIndex(t => t.match === datum.match),
),
[data],
);

const chartConfig = {
backgroundGradientFrom: colors.card,
backgroundGradientFromOpacity: 1.0,
Expand Down Expand Up @@ -65,23 +76,17 @@ function QuestionSummary({item, index, data, generate_ai_summary}: Props) {
useEffect(() => {
if (item.type === 'number') {
const avg =
data.map(datum => datum.data).reduce((a, b) => a + b, 0) / data.length;
const max = Math.max(...data.map(datum => datum.data));
const min = Math.min(...data.map(datum => datum.data));
processedData.map(datum => datum.data).reduce((a, b) => a + b, 0) /
processedData.length;
const max = Math.max(...processedData.map(datum => datum.data));
const min = Math.min(...processedData.map(datum => datum.data));
setStats({average: avg, max: max, min: min});

// sort data by match number
data.sort((a, b) => {
return a.match - b.match;
});

// TODO: remove duplicate data points (determined by match number)
}

if (item.type === 'radio') {
let counts: number[] = [];
for (let i = 0; i < item.options.length; i++) {
counts.push(data.filter(datum => datum.data === i).length);
counts.push(processedData.filter(datum => datum.data === i).length);
}
const index = counts.indexOf(Math.max(...counts));

Expand Down Expand Up @@ -322,10 +327,10 @@ function QuestionSummary({item, index, data, generate_ai_summary}: Props) {
<View>
<LineChart
data={{
labels: data.map(datum => String(datum.match)),
labels: processedData.map(datum => String(datum.match)),
datasets: [
{
data: data.map(datum => datum.data),
data: processedData.map(datum => datum.data),
strokeWidth: 2, // optional
},
],
Expand Down