Honor windIO flow-field bounds; regression test for statistical flow field - #66
Open
kilojoules wants to merge 1 commit into
Open
Honor windIO flow-field bounds; regression test for statistical flow field#66kilojoules wants to merge 1 commit into
kilojoules wants to merge 1 commit into
Conversation
Flow-field output for statistical (wind rose) input works since the run_pywake decomposition; add a regression test that runs a Weibull rose and checks FarmFlow.nc contents. The bounds override read z_planes keys xlb/xub/ylb/yub, which windIO does not define — every example uses x_bounds/y_bounds, so requested bounds were silently ignored and the flow box always fell back to the site bounding box. Read the windIO keys instead. Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things around GH #7 ("PyWake doesn't output flow field for statistical input"):
FarmFlow.ncis written withwind_speed/turbulence_intensityover (x, y, z, wd, ws). Added a regression test that runs a Weibull rose and checks the file contents.z_planeskeysxlb/xub/ylb/yub, which windIO does not define. Every example usesx_bounds/y_bounds, so user-requested bounds were silently ignored and the flow box always fell back to the site bounding box. Now reads the windIO keys.Closes #7
🤖 Generated with Claude Code