Repository navigation
Conversation
mvertens
marked this pull request as draft
October 7, 2026 11:01
maritsandstad
approved these changes
Oct 7, 2026
maritsandstad
left a comment
maritsandstad
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, assuming you have tested and this solves the bounds issue for cice. which it seems to me to do
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
….yaml to noresm_grids.yaml
… and ne30->NorESM3-MM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a fix for #115
siuandsivsit on the B-grid velocity point, but were written with cell-centre coordinates:Now, each variable's own
coordinatesattribute decides which pair it gets, and the matching bounds come with it. TThe grid names live in
grids.pywith the other grid facts, so the writer and the driver read one list.New addition of 20 tests.
Testing: TBD