Use Geoweaver API + Better UI Response (Pandas + IPython Widgets)#24
Use Geoweaver API + Better UI Response (Pandas + IPython Widgets)#24gokulprathin8 wants to merge 19 commits into
Conversation
|
Here is the testing changes for the changed functions @ZihengSun couldnt upload my local file of jupyter notebook, so uploaded to colab and pasted link here |
| d = d.json() | ||
| d['nodes'] = json.loads(d['nodes']) | ||
| try: | ||
| from IPython import get_ipython |
There was a problem hiding this comment.
this section of code is repeated in all the places. Can you make it a function and reuse it when being used?
| ], | ||
| cwd=f"{get_root_dir()}/", | ||
| ) | ||
| url = f"{GEOWEAVER_DEFAULT_ENDPOINT_URL}/web/detail" |
There was a problem hiding this comment.
this whole section is repeated multiple times. Need to Create a utility function and reduce the redundancy please
| ], | ||
| cwd=f"{get_root_dir()}/", | ||
| ) | ||
| url = f"{GEOWEAVER_DEFAULT_ENDPOINT_URL}/web/detail" |
There was a problem hiding this comment.
Redundancy section of code. Use utility function.
| shutil.copy2(source_file, destination_file) | ||
|
|
||
|
|
||
| def create_table(data, max_length=100): |
There was a problem hiding this comment.
Not sure this is a good idea. Also, a table is not impressive improvement comparing to all the other libraries. What we need is a widget that have button and dropdown, selection, text editors, or things similar that. Here is some example: https://medium.com/codex/fancy-world-of-ipywidgets-e3301de58bd7
Overall, people like interactive experiences. Not just a static table. If it is only a simple HTML table, the pandas dataframe output will do it.
ZihengSun
left a comment
ZihengSun
left a comment
There was a problem hiding this comment.
Some comments and it should be an interactive widget. A simple HTML table doesn't worth the efforts.
2 participants
No description provided.