Implicit deallocation in RtmMod.F90 for qSend

[ekluzek]

There's a missing deallocation for qSend in RtmMod.F90. It allocates it each time route_ini is called and doesn't deallocate it. It should deallcate at the end of route_run, or do the allocation in route_ini, and don't worry about deallocating.

Note, I was able to use "git grep allocate" to show this in route/build/cpl, as other instances showed a matching deallocate, or the allocates in RunoffMod.F90 and rof_import_export.F90 didn't have a matching deallocate -- but they are only done at initialization. So those ones are OK.

Since it's a local allocatable array, the compiler will deallocate when it goes out of scope. So there is an implicit deallocation going on. But, that makes it harder to match deallocates with allocates and know that's being properaly handled.

[ekluzek]

There may be missing deallocates in the main code as well, but it's harder to evaluate as many things are allocated at initialzation and just left throughout execution. But, it's possible there are missing deallocates in the main code as well.

[nmizukami]

I understood that for Fortran, a local allocatable array in subroutine automatically get deallocated when the code leaves the subroutine, unless it does have the SAVE attribute?

[ekluzek]

I understood that for Fortran, a local allocatable array in subroutine automatically get deallocated when the code leaves the subroutine, unless it does have the SAVE attribute?

Ahhh, yes that is correct!

The thing is that the easy way to check if things are deallocated is to look for the maching deallocate to the allocate statement. It's hard to evaluate that this is a local allocate that the compiler will deallocate when it goes out of scope. Which makes me think it might be worth doing for code asesethics. And I can't guarantee I won't forget that again, and point it out in the future. It's not something we look at very often.

So I could go either way on this. I'm glad it's not a real bug, I would've thought we woudl've seen it before now if it really was.