Skip to content

Fix cplhist test#415

Merged
ekluzek merged 4 commits into
ESCOMP:mainfrom
ekluzek:fix_cplhist_test
Jun 30, 2026
Merged

Fix cplhist test#415
ekluzek merged 4 commits into
ESCOMP:mainfrom
ekluzek:fix_cplhist_test

Conversation

@ekluzek

@ekluzek ekluzek commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Description of changes

Add back the cplhist test to aux_cdeps testlist after fixing it so that it actually works. It needed dtlimit increased to a large value so that it would work.

Specific notes

Contributors other than yourself, if any: @billsacks

CDEPS Issues Fixed (include github issue #):
Fixes #408

Are there dependencies on other component PRs (if so list): No

Are changes expected to change answers (bfb, different to roundoff, more substantial): No

Any User Interface Changes (namelist or namelist defaults changes):
Changes dtlimit for CPLHIST streams to 1.e30

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
Running aux_cdeps compared to cesm3_0_alpha09c

Hashes used for testing:
cesm: cesm3_0_alpha09c
cdeps: 90978df
cmeps: cmeps1.1.51

@ekluzek ekluzek added CESM Only Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group labels Jun 25, 2026
@ekluzek ekluzek moved this from Todo to In Progress in LMWG: Sprint Planning Board Jun 25, 2026
@billsacks

Copy link
Copy Markdown
Member

@ekluzek - can you explain the need for the huge dtlimit? Is this something we want in general for cplhist forcings, or is it just something needed as a workaround for the current files used in the test that you're adding?

@ekluzek

ekluzek commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

@ekluzek - can you explain the need for the huge dtlimit? Is this something we want in general for cplhist forcings, or is it just something needed as a workaround for the current files used in the test that you're adding?

Hi @billsacks I haven't tracked it through for sure. But I think this is a feature that happens when cycle is chosen and you have a time step before the first data sample. So dtmin is the time of the first time sample and dtmax is the time of the last time sample in the series. So the ratio of the two ends up being large and doesn't have a reasonable bounds. So the dtlimit check isn't reasonable in these cases.

This is something that we really should fix in the streams logic regarding dtlimit.

But the choice of 1e30 is just done because that's the value used in other cases like this that need a large value.

So I think it's acceptable for now.

@ekluzek

ekluzek commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

In testing three DGLC tests failed and must be for other reasons. So I'll verify they failed beforehand.

@billsacks billsacks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation about dtlimit, @ekluzek . I'm approving based on that. Let me know when you feel this is ready to merge.

@ekluzek

ekluzek commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

OK, when I updated cmeps to cmeps1.1.51 the DGLC tests pass.

@ekluzek

ekluzek commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

This was approved and it's simple, and I have permission to merge, so I'm going ahead and merging it in.

@ekluzek ekluzek merged commit eafdf89 into ESCOMP:main Jun 30, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in LMWG: Sprint Planning Board Jun 30, 2026
@ekluzek ekluzek deleted the fix_cplhist_test branch June 30, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CESM Only Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

DATM CPLHIST test needs to be fixed and then restored

2 participants