Fix cplhist test#415
Conversation
|
@ekluzek - can you explain the need for the huge dtlimit? Is this something we want in general for cplhist forcings, or is it just something needed as a workaround for the current files used in the test that you're adding? |
Hi @billsacks I haven't tracked it through for sure. But I think this is a feature that happens when cycle is chosen and you have a time step before the first data sample. So dtmin is the time of the first time sample and dtmax is the time of the last time sample in the series. So the ratio of the two ends up being large and doesn't have a reasonable bounds. So the dtlimit check isn't reasonable in these cases. This is something that we really should fix in the streams logic regarding dtlimit. But the choice of 1e30 is just done because that's the value used in other cases like this that need a large value. So I think it's acceptable for now. |
|
In testing three DGLC tests failed and must be for other reasons. So I'll verify they failed beforehand. |
|
OK, when I updated cmeps to cmeps1.1.51 the DGLC tests pass. |
|
This was approved and it's simple, and I have permission to merge, so I'm going ahead and merging it in. |
Description of changes
Add back the cplhist test to aux_cdeps testlist after fixing it so that it actually works. It needed dtlimit increased to a large value so that it would work.
Specific notes
Contributors other than yourself, if any: @billsacks
CDEPS Issues Fixed (include github issue #):
Fixes #408
Are there dependencies on other component PRs (if so list): No
Are changes expected to change answers (bfb, different to roundoff, more substantial): No
Any User Interface Changes (namelist or namelist defaults changes):
Changes dtlimit for CPLHIST streams to 1.e30
Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
Running aux_cdeps compared to cesm3_0_alpha09c
Hashes used for testing:
cesm: cesm3_0_alpha09c
cdeps: 90978df
cmeps: cmeps1.1.51