Immediately return after fixing column - #3290
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3290 +/- ##
==========================================
- Coverage 73.33% 73.33% -0.01%
==========================================
Files 446 446
Lines 108441 108475 +34
Branches 17363 17364 +1
==========================================
+ Hits 79524 79548 +24
- Misses 28641 28651 +10
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fwesselm
approved these changes
Sep 15, 2026
Collaborator
There was a problem hiding this comment.
Sorry, @Opt-Mucca, this is my fault.
Please merge (after making the similar change for the upper bound case)!
EDIT: I can just add this. I hope that is OK.
…ominated-col-double-fixing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's an issue with
dominatedColumns, where a truly redundant column may be able to be fixed to either its lower or its upper bound, and the code will try to fix to both one-after-another. This raises an error when it tries to fix an already deleted column. The code-fix is to return after fixing the column to one side.This was found by looking at a failing instance on my clique table changes.
Checklist
latestbranch