Skip to content

Fix issue 2900 - #3234

Merged
jajhall merged 3 commits into
ERGO-Code:latestfrom
fwesselm:fix-2900
Aug 26, 2026
Merged

Fix issue 2900#3234
jajhall merged 3 commits into
ERGO-Code:latestfrom
fwesselm:fix-2900

Conversation

@fwesselm

@fwesselm fwesselm commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix #2900:

  • Upgraded computations in cover loop to HighsCDouble in HPresolve::strengthenInequalities.
  • Added a test.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

@fwesselm
fwesselm requested a review from Opt-Mucca August 26, 2026 08:40
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.22%. Comparing base (c814f2f) to head (76ec5f9).
⚠️ Report is 7 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3234      +/-   ##
==========================================
+ Coverage   73.20%   73.22%   +0.01%     
==========================================
  Files         445      445              
  Lines      107981   108027      +46     
  Branches    17308    17317       +9     
==========================================
+ Hits        79043    79098      +55     
+ Misses      28662    28653       -9     
  Partials      276      276              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Opt-Mucca Opt-Mucca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much like that we're catching up with these cases! Those max and min convenience functions are also going to be helpful.

@jajhall
jajhall merged commit 7a425e4 into ERGO-Code:latest Aug 26, 2026
369 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants