Initialize optimal objective value

[fwesselm]

Description

[435 / 496] 9 / 39 tests; Compiling check/TestQpOracle.cpp; 2s processwrapper-sandbox ... (4 actions running)
INFO: From Compiling check/TestQpOracle.cpp:
In file included from check/TestQpOracle.cpp:6:
check/TestQpOracle.cpp: In function 'void C_A_T_C_H_T_E_S_T_4()':
check/TestQpOracle.cpp:472:29: warning: 'optimal_obective_value' may be used uninitialized [-Wmaybe-uninitialized]
  472 |       REQUIRE(valuesRelEqual(h.getObjectiveValue(), optimal_obective_value));
      |               ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check/TestQpOracle.cpp:462:10: note: 'optimal_obective_value' was declared here
  462 |   double optimal_obective_value;
      |          ^~~~~~~~~~~~~~~~~~~~~~

Checklist

• I have read the contributing guidelines
• This PR targets the latest branch
• Tests are passing
• Documentation was updated where relevant
• This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.21%. Comparing base (76e6732) to head (f3a6291).
⚠️ Report is 12 commits behind head on latest.

Additional details and impacted files

@@           Coverage Diff           @@
##           latest    #3231   +/-   ##
=======================================
  Coverage   73.20%   73.21%           
=======================================
  Files         445      445           
  Lines      107876   107890   +14     
  Branches    17282    17278    -4     
=======================================
+ Hits        78970    78990   +20     
+ Misses      28630    28624    -6     
  Partials      276      276           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jajhall]

Fair enough, although it will be assigned as long as kQpAsmString comes before kHipoStringin solvers.

More importantly,

std::remove(write_model_filename.c_str());

is commented out, so a temporary file is not deleted during ctest. Please would you uncomment these lines.

[fwesselm]

Fair enough, although it will be assigned as long as kQpAsmString comes before kHipoStringin solvers.

More importantly,

std::remove(write_model_filename.c_str());

is commented out, so a temporary file is not deleted during ctest. Please would you uncomment these lines.

Oh, I should have seen that. Uncommented.