Skip to content

Enforces epsilon minimum bound checks #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Opt-Mucca merged 1 commit into from
Aug 24, 2026
Merged

Enforces epsilon minimum bound checks #3224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions highs/presolve/HPresolve.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3450,7 +3450,9 @@ HPresolve::Result HPresolve::singletonRow(HighsPostsolveStack& postsolve_stack,

// use either the primal feasibility tolerance for the bound constraint or
// for the singleton row including scaling, whichever is tighter.
const double boundTol = primal_feastol / std::max(1.0, std::fabs(val));
const double boundTol =
std::max(primal_feastol / std::max(1.0, std::fabs(val)),
std::numeric_limits<double>::epsilon());
const bool isIntegral = model->integrality_[col] != HighsVarType::kContinuous;

bool lowerTightened = newColLower > model->col_lower_[col] + boundTol;
Expand Down Expand Up @@ -4547,7 +4549,8 @@ HPresolve::Result HPresolve::rowPresolve(HighsPostsolveStack& postsolve_stack,
direction * impliedRowBound == kHighsInf ||
abs(static_cast<HighsCDouble>(rowSide) -
static_cast<HighsCDouble>(impliedRowBound)) >
primal_feastol / dynamism)
std::max(static_cast<double>(primal_feastol / dynamism),
std::numeric_limits<double>::epsilon()))
return Result::kOk;

// get stored row
Expand Down Expand Up @@ -4907,7 +4910,9 @@ HPresolve::Result HPresolve::detectDominatedCol(
: -impliedDualRowBounds.getSumLowerOrig(
col, -model->col_cost_[col]);
if (std::abs(boundOnColDual) <=
options->dual_feasibility_tolerance / dynamism) {
std::max(static_cast<double>(options->dual_feasibility_tolerance /
dynamism),
std::numeric_limits<double>::epsilon())) {
// 1. column dual's upper bound is zero (since the column's lower bound
// is infinite) and column dual's lower bound is zero as well
// (direction = 1) or
Expand Down
Loading