Skip to content

Fix #3216 - #3220

Merged
jajhall merged 4 commits into
latestfrom
fix-3216-2
Aug 19, 2026
Merged

Fix #3216#3220
jajhall merged 4 commits into
latestfrom
fix-3216-2

Conversation

@fwesselm

@fwesselm fwesselm commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Fix #3216

  • Correctly fix last non-fixed entry in equality cliques.
  • Do not exit early when making bound modifications in HPresolve::finaliseProbing.
  • Added a unit test.

@fwesselm
fwesselm requested review from Opt-Mucca and jajhall August 18, 2026 11:50
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.06%. Comparing base (2aefdbf) to head (2ed99be).
⚠️ Report is 4 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3220      +/-   ##
==========================================
+ Coverage   73.04%   73.06%   +0.01%     
==========================================
  Files         445      445              
  Lines      107591   107661      +70     
  Branches    17250    17257       +7     
==========================================
+ Hits        78591    78659      +68     
- Misses      28724    28726       +2     
  Partials      276      276              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Opt-Mucca Opt-Mucca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I've left a comment because I'm not sure how all cases are handled.

Comment thread highs/mip/HighsCliqueTable.cpp
Comment thread highs/mip/HighsCliqueTable.cpp

@jajhall jajhall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the technical side of clique removal, but if this fixes #3216 and has two unit tests to validate the fix and for code coverage, then it's good with me

@jajhall
jajhall merged commit b7d4e98 into latest Aug 19, 2026
536 of 538 checks passed
@jajhall
jajhall deleted the fix-3216-2 branch August 19, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants