Presolve infrastructure for adding rows/columns - #3218
Merged
Conversation
…olveAddRowsDebugging3
…olveAddRowsDebugging5
…olveAddRowsDebugging6
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3218 +/- ##
==========================================
+ Coverage 73.06% 73.13% +0.07%
==========================================
Files 445 445
Lines 107661 107796 +135
Branches 17257 17260 +3
==========================================
+ Hits 78659 78835 +176
+ Misses 28726 28685 -41
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Opt-Mucca
reviewed
Aug 19, 2026
Opt-Mucca
left a comment
Collaborator
There was a problem hiding this comment.
I am a hugeeeeeeeeeeeeeeeeee fan of this PR!!!!! It somehow doesn't complicate the code at all, and even does a latent TODO for equation upgrades!
I've only found two potential issues. Both could be me missing the larger picture (not unlikely), but I think they're potential bugs.
…esolve5-peripheral
…esolve5-peripheral
Opt-Mucca
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImpliedEquationreduction type was added to properly handle conversion of inequality constraints into equality constraints.