Skip to content

Reduce amount of duplicate code in HighsSymmetry - #3215

Merged
fwesselm merged 10 commits into
ERGO-Code:latestfrom
fwesselm:symmetryNewMethods
Aug 14, 2026
Merged

Reduce amount of duplicate code in HighsSymmetry#3215
fwesselm merged 10 commits into
ERGO-Code:latestfrom
fwesselm:symmetryNewMethods

Conversation

@fwesselm

Copy link
Copy Markdown
Collaborator

Added methods to reduce amount of similar/duplicate code in HighsSymmetry class

@fwesselm
fwesselm requested a review from Opt-Mucca August 12, 2026 12:46
@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.64045% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.04%. Comparing base (b196d7a) to head (79b0314).
⚠️ Report is 3 commits behind head on latest.

Files with missing lines Patch % Lines
highs/presolve/HighsSymmetry.cpp 69.23% 32 Missing ⚠️
check/TestSymmetry.cpp 99.38% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3215      +/-   ##
==========================================
+ Coverage   72.77%   73.04%   +0.26%     
==========================================
  Files         444      445       +1     
  Lines      107469   107591     +122     
  Branches    17290    17248      -42     
==========================================
+ Hits        78213    78589     +376     
+ Misses      28979    28726     -253     
+ Partials      277      276       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Opt-Mucca Opt-Mucca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fwesselm

Copy link
Copy Markdown
Collaborator Author

Looks good!

@Opt-Mucca, I added a test for this. I hope you agree that this is worth having.

@Opt-Mucca

Copy link
Copy Markdown
Collaborator

@fwesselm tests are rarely worth not having. I didn't expect you manage to more code simplifications too! Happy the new changes as well.

@fwesselm
fwesselm merged commit 076e004 into ERGO-Code:latest Aug 14, 2026
518 of 520 checks passed
@fwesselm
fwesselm deleted the symmetryNewMethods branch August 14, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants