Reduce amount of duplicate code in HighsSymmetry - #3215
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3215 +/- ##
==========================================
+ Coverage 72.77% 73.04% +0.26%
==========================================
Files 444 445 +1
Lines 107469 107591 +122
Branches 17290 17248 -42
==========================================
+ Hits 78213 78589 +376
+ Misses 28979 28726 -253
+ Partials 277 276 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
@Opt-Mucca, I added a test for this. I hope you agree that this is worth having. |
Collaborator
|
@fwesselm tests are rarely worth not having. I didn't expect you manage to more code simplifications too! Happy the new changes as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added methods to reduce amount of similar/duplicate code in
HighsSymmetryclass